Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump System.Reflection.MetadataLoadContext from 7.0.0 to 8.0.0 #1734

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 15, 2023

Bumps System.Reflection.MetadataLoadContext from 7.0.0 to 8.0.0.

Release notes

Sourced from System.Reflection.MetadataLoadContext's releases.

.NET 8.0.0

Release

.NET 8.0 RC 2

Release

.NET 8.0 RC 1

Release

.NET 8.0 Preview 7

Release

.NET 8.0 Preview 6

Release

.NET 8.0 Preview 5

Release

.NET 8.0 Preview 4

Release

.NET 8.0 Preview 3

Release

.NET 8.0 Preview 2

Release

.NET 8.0 Preview 1

Release

.NET 7.0.14

Release

.NET 7.0.13

Release

.NET 7.0.12

Release

.NET 7.0.11

Release

.NET 7.0.10

Release

.NET 7.0.9

Release

.NET 7.0.8

Release

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner November 15, 2023 08:55
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 15, 2023
@DaveTryon
Copy link
Contributor

I've requested harvesting at ClearlyDefined.io.

@DaveTryon DaveTryon added the pr: do not merge This pull request should not be merged. label Nov 15, 2023
@DaveTryon
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 15, 2023

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@DaveTryon
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DaveTryon
Copy link
Contributor

DaveTryon commented Nov 16, 2023

Based on the following stack being thrown in tests, it seems that internal changes to System.Reflection.MetadataLoadContext.dll have led to unmet dependencies on System.Runtime.CompilerServices.Unsafe.dll:

   Test method ManifestTests.IntegrationTests.EmbeddedManifestMatchesRawManifest threw exception: 
System.TypeInitializationException: The type initializer for 'PerTypeValues`1' threw an exception. ---> System.IO.FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
  Stack Trace:
      at System.SpanHelpers.PerTypeValues`1.MeasureArrayAdjustment()
   at System.SpanHelpers.PerTypeValues`1..cctor()
--- End of inner exception stack trace ---
    at System.SpanHelpers.IsReferenceOrContainsReferences[T]()
   at System.Reflection.Internal.MemoryBlock.GetUtf8NullTerminatedLength(Int32 offset, Int32& numberOfBytesRead, Char terminator)
   at System.Reflection.Metadata.MetadataReader.ReadMetadataHeader(BlobReader& memReader, String& versionString)
   at System.Reflection.Metadata.MetadataReader..ctor(Byte* metadata, Int32 length, MetadataReaderOptions options, MetadataStringDecoder utf8Decoder, Object memoryOwner)
   at System.Reflection.Metadata.PEReaderExtensions.GetMetadataReader(PEReader peReader, MetadataReaderOptions options, MetadataStringDecoder utf8Decoder)
   at System.Reflection.Metadata.PEReaderExtensions.GetMetadataReader(PEReader peReader)
   at AccessibilityInsights.SetupLibrary.FileHelpers.ExtractResourceFromStream(Stream stream, String resourceName) in D:\a\1\s\src\AccessibilityInsights.SetupLibrary\FileHelpers.cs:line 84
   at AccessibilityInsights.SetupLibrary.ChannelInfoUtilities.GetChannelInfoFromSignedManifest(Stream stream, Func`2 streamTrustCheck) in D:\a\1\s\src\AccessibilityInsights.SetupLibrary\ChannelInfoUtilities.cs:line 50
   at ManifestTests.IntegrationTests.EmbeddedManifestMatchesRawManifest() in D:\a\1\s\src\ManifestTests\IntegrationTests.cs:line 70

Locally, I tried adding System.Runtime.CompilerServices.Unsafe as a NuGet dependency for the SetupLibrary project, but it didn't fix the problem. Shouldn't be hard to fix, but not a blocker and not a high priority.

@DaveTryon DaveTryon added status: blocked This issue is blocked. and removed pr: do not merge This pull request should not be merged. labels Nov 16, 2023
@DaveTryon DaveTryon closed this Jan 3, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 3, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@DaveTryon DaveTryon reopened this Jan 3, 2024
Bumps [System.Reflection.MetadataLoadContext](https://github.com/dotnet/runtime) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v7.0.0...v8.0.0)

---
updated-dependencies:
- dependency-name: System.Reflection.MetadataLoadContext
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/System.Reflection.MetadataLoadContext-8.0.0 branch from 4181a3d to 3a387e7 Compare January 3, 2024 23:30
@DaveTryon
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DaveTryon DaveTryon closed this Jan 16, 2024
@DaveTryon DaveTryon reopened this Jan 16, 2024
@DaveTryon
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-sharmachir
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status: blocked This issue is blocked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants