Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello-world and QAOA samples from Pasqal #607

Merged
merged 21 commits into from
Jun 25, 2024

Conversation

ArnaudPel
Copy link
Contributor

One of the final tasks required to complete the integration of Pasqal as an Azure Quantum provider was to provide sample notebooks, which is what this PR attempts to do.

@ArnaudPel ArnaudPel requested a review from a team as a code owner May 7, 2024 12:50
@ArnaudPel
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Pasqal"

ArnaudPel and others added 2 commits May 7, 2024 16:49
Co-authored-by: Nicolas Ménétrier <nicolas.menetrier@gmail.com>
Copy link

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ! I am just letting a couple of comments on syntax and QAOA :)

Co-authored-by: Antoine Cornillot <61453516+a-corni@users.noreply.github.com>
@ArnaudPel
Copy link
Contributor Author

FYI while re-testing the HW notebook this morning, I faced a new error which I was not seeing ~15h ago:

'DIGITALANALOGDEVICE' is not a valid DeviceTypeName

We are investigating this internally.

@ArnaudPel
Copy link
Contributor Author

FYI while re-testing the HW notebook this morning, I faced a new error which I was not seeing ~15h ago:

'DIGITALANALOGDEVICE' is not a valid DeviceTypeName

We are investigating this internally.

This was due to an incorrect target being used, following the application of one of the suggestions. Now fixed by reinstating

target = workspace.get_targets(name="pasqal.sim.emu-tn")

Thanks @nmenetrier !

@ArnaudPel
Copy link
Contributor Author

@kikomiss I think that all threads have been addressed, we might be good to go 😀 🤞

@ArnaudPel
Copy link
Contributor Author

Hello ! Sending a little reminder to see if we can merge this PR 😀

@kikomiss
Copy link
Contributor

Hello ! Sending a little reminder to see if we can merge this PR 😀

@ArnaudPel I apologize, for the delay with review. I've left a couple of nit comments and a suggestion on qaoa-for-quadratic-unconstrained-binary-optimization.ipynb.

@kikomiss kikomiss merged commit 3a2f2f1 into microsoft:main Jun 25, 2024
7 checks passed
@ArnaudPel ArnaudPel deleted the arnaudpel/pasqal-samples branch June 25, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants