migrate QIR backends to V2 output format by default #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarzc
reviewed
Jul 17, 2024
LawsonGraham
force-pushed
the
t-lgraham/qiskit-v2-output-default
branch
from
3f7aa66
to
4d86621
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LawsonGraham
force-pushed
the
t-lgraham/qiskit-v2-output-default
branch
from
04fd914
to
4d8a7cd
Compare
added 15 commits
July 23, 2024 10:21
LawsonGraham
force-pushed
the
t-lgraham/qiskit-v2-output-default
branch
from
7b68188
to
d80d4c3
Compare
cesarzc
reviewed
Jul 24, 2024
|
The logic changes look good, thanks @LawsonGraham. We should just do our due diligence checking QIR generation for each gateset. @kikomiss, when you have a chance, could you please take a look at the updated recordings? I reviewed them and they look ok, but it would be good to have a second set of eyes on them. |
LawsonGraham
force-pushed
the
t-lgraham/qiskit-v2-output-default
branch
from
3f0bea8
to
ddbebfc
Compare
kikomiss
approved these changes
Aug 5, 2024
LawsonGraham
pushed a commit
to LawsonGraham/azure-quantum-python
that referenced
this pull request
Aug 6, 2024
kikomiss
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading the QIR backends to handle and use V2 output format by default, enabling
get_memory()to be callable for users. also fixing construction of theget_counts()method to use real counts vs. synthetic counts from probablilities