Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input ELF file using everparse #807

Closed

Conversation

Alan-Jowett
Copy link
Member

@Alan-Jowett Alan-Jowett commented Mar 14, 2022

Validate input ELF file using Everparse.

Everparse generated files are checked in until #834 is fixed.

Signed-off-by: Alan Jowett alanjo@microsoft.com

Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See early feedback, glad to see this progress.

spec/Elf.3d Outdated Show resolved Hide resolved
spec/elf/Elf.c Show resolved Hide resolved
spec/elf/EverParse.h Show resolved Hide resolved
spec/elf/EverParseEndianness.h Show resolved Hide resolved
tools/bpf2c/bpf_code_generator.h Outdated Show resolved Hide resolved
@Alan-Jowett Alan-Jowett marked this pull request as ready for review March 25, 2022 16:18
spec/elf/elf.vcxproj Outdated Show resolved Hide resolved
spec/spec.md Show resolved Hide resolved
tools/bpf2c/bpf2c.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR uses everparse in the bpf2c tool, should we use everparse in the JIT workflow as well?

Everparse generated files are checked in until microsoft#834 is fixed.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #807 (77922e1) into main (68a7402) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   29.83%   29.83%           
=======================================
  Files           3        3           
  Lines         781      781           
  Branches      488      488           
=======================================
  Hits          233      233           
  Misses        257      257           
  Partials      291      291           
Impacted Files Coverage Δ
tools/bpf2c/bpf_code_generator.cpp 36.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a7402...77922e1. Read the comment docs.

@Alan-Jowett Alan-Jowett marked this pull request as draft April 6, 2022 02:53
@Alan-Jowett
Copy link
Member Author

Converting to draft until I have a plan for ebpf-verifier integration.

@Alan-Jowett
Copy link
Member Author

Need to integrate with new everparse nuget package. Will re-open when it's ready.

@Alan-Jowett Alan-Jowett closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants