Show Find and Replace in centered dialogs - #932
Open
kisaraki wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move Find and Replace from the rows above the document into centered modal dialogs.
Behavior
Scope
This PR changes only the Find/Replace presentation and interaction in:
crates/edit/src/bin/edit/draw_editor.rscrates/edit/src/bin/edit/main.rsIt does not include customized About content, version/authorship changes, copyright-header changes, themes, Markdown navigation, deployment scripts, or other features.
Validation
cargo fmt --all -- --checkcargo test -p edit --bin editcargo build -p edit --release --lockedcargo test -p edit --bin editcargo build -p edit --release --lockedAll commands completed successfully. Both release binaries report
edit version 2.0.0.Contribution
These changes are my original personal work, unrelated to any organization or company, and not created in the course of employment. I agree to contribute them under the Microsoft Contributor License Agreement and the project's MIT License.