Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvfs-helper: simplify progress output during prefetch #594

Merged
merged 2 commits into from
Aug 8, 2023
Merged

gvfs-helper: simplify progress output during prefetch #594

merged 2 commits into from
Aug 8, 2023

Commits on Aug 7, 2023

  1. gvfs-helper: stop showing index-pack progress 

    If we are showing progress, then we should do so only for how many
prefetch packs are being downloaded. Stop sending the '-v' option to
'git index-pack' which creates too much noise.

Signed-off-by: Derrick Stolee <derrickstolee@github.com>
    @derrickstolee
    derrickstolee committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4c999ac View commit details
    Browse the repository at this point in the history

  2. gvfs-helper: show progress of multiple prefetch packs 

    When using a cache server to download multiple prefetch packs, the GVFS
Protocol sends all packs in one download. This download is split into
multiple files during that single HTTPS request. This also presents a
single progress indicator such as

  Prefetch 1691384600 (2023-08-07 05:03:20 +0000) (bytes received): 25355702, done.

After downloading all of these packs to the `tempPacks` directory of the
shared object cache, we run `git index-pack` on each packfile
individually.

The previous change removed the verbose output of `git index-pack`, but
that left the time spend indexing the packs without any progress
indicator.

Add a new progress indicator that ticks through the different prefetch
pack-files that are being installed as we go. This presents a new
progress indicator that terminates with output like

  Installing prefetch packfiles: 100% (14/14), done.

This helps users understand what is going on without the extra noise of
two output lines per `git index-pack` command.

Signed-off-by: Derrick Stolee <derrickstolee@github.com>
    @derrickstolee
    derrickstolee committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3981c02 View commit details
    Browse the repository at this point in the history