Add page number to Memory Records. #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkampfergit
force-pushed
the
feature/pages-in-memoryrecords
branch
2 times, most recently
from
47ee726
to
045cc1b
Compare
alkampfergit
changed the title
dluc
reviewed
Jul 26, 2024
alkampfergit
force-pushed
the
feature/pages-in-memoryrecords
branch
2 times, most recently
from
71bd5ac
to
2e331c1
Compare
This branch introduces a new TextPartitioning Handler that supports pages numbering in pdf.
alkampfergit
force-pushed
the
feature/pages-in-memoryrecords
branch
from
2e331c1
to
ec6cfdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
I'd like to solve discussion #669 the ability to insert page number inside Memory Record in the Section property.
High level description (Approach, Design)
Introduced a new TextChunker2 that allows for specification of a series of line with a tag, then it will split based on token number, but instead of creating simple lines in output it will preserve the tag of the original line. I've chosen a tag object so we can add more info if needed, in this PR I've added the plain page number.
Needs to check if the overall implant of the PR is ok, then I'll finish implementation and testing of TextChunk2. Actually we can even validate that TextChunk2 is the only one chunker (it works exactly as TextChunk with the only addition of keeping tracks of a tag associated to a piece of text).