Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rsh/url replace handler #494

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Rsh/url replace handler #494

merged 8 commits into from
Jul 20, 2023

Conversation

ramsessanchez
Copy link
Contributor

URL replace handler added to the Http/Okhttp component.
Tied to Java-Core pr: microsoftgraph/msgraph-sdk-java-core#974

@ramsessanchez ramsessanchez mentioned this pull request Jul 19, 2023
Merged
andrueastman
andrueastman reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to change the version number in the changelog/gradle.properties.

components/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/UrlReplaceHandler.java Outdated Show resolved Hide resolved
components/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/UrlReplaceHandler.java Show resolved Hide resolved
@ramsessanchez @andrueastman
Update components/http/okHttp/src/main/java/com/microsoft/kiota/http/…
cec3ff4 
…middleware/UrlReplaceHandler.java

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@ramsessanchez
Update UrlReplaceHandler.java
5a42ba3 
javadoc corrections
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@baywet baywet merged commit 0162d03 into main Jul 20, 2023
10 checks passed
@baywet baywet deleted the rsh/Url_replace_handler branch July 20, 2023 18:07
@ramsessanchez ramsessanchez linked an issue Jul 20, 2023 that may be closed by this pull request
Skip generation for the /me endpoints microsoftgraph/msgraph-sdk-java#1437
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip generation for the /me endpoints
3 participants
@ramsessanchez @andrueastman @baywet