Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- adds headers inspection middleware #575

Merged
merged 3 commits into from
Aug 14, 2023
Merged

- adds headers inspection middleware #575

merged 3 commits into from
Aug 14, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Aug 14, 2023

@baywet baywet self-assigned this Aug 14, 2023
Base automatically changed from jakarta_annotations to main August 14, 2023 18:03
@baywet baywet enabled auto-merge August 14, 2023 18:21
@baywet
- adds missing nullability annotation
36d2a8a
@baywet
- fixes indent
f12e357 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

ramsessanchez
ramsessanchez approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@ramsessanchez ramsessanchez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to add a feature flag value in Java-Core to track the usage of this handler in the telemetry.

@baywet baywet merged commit 1a1fc24 into main Aug 14, 2023
9 of 10 checks passed
@baywet baywet deleted the feature/header-observe branch August 14, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramsessanchez ramsessanchez ramsessanchez approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @ramsessanchez