Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds periodAndDuration constructor using a periodAndDuration value. #577

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Adds periodAndDuration constructor using a periodAndDuration value. #577

merged 2 commits into from
Aug 21, 2023

Conversation

ramsessanchez
Copy link
Contributor

@ramsessanchez
Copy link
Contributor Author

@baywet @andrueastman would this constitute a minor version bump?

baywet
baywet requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please bump the patch (such a minor change) + changelog entry

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramsessanchez ramsessanchez merged commit c62a622 into main Aug 21, 2023
10 checks passed
@ramsessanchez ramsessanchez deleted the periodAndDurationConstructor branch August 21, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramsessanchez @andrueastman @baywet