#585 Prevent decoding of parameter values in the ParametersNameDecodingHandler Interceptor & write corresponding test case #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the ParametersNameDecodingHandler Interceptor & write corresponding test case
Avzel
requested review from
baywet,
MIchaelMainer,
zengin,
ramsessanchez and
andrueastman
as code owners
|
@microsoft-github-policy-service agree |
andrueastman
reviewed
Sep 4, 2023
There was a problem hiding this comment.
Thanks for the contribution here @Avzel
Any chance change you can bump up the version number in the gradle.properties file and add a changelog entry in changelog.md before we merge?
@andrueastman Sure not a problem, I just committed those updates |
andrueastman
approved these changes
Sep 5, 2023
|
Thanks for the contribution @Avzel ! publishing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #585, ensuring that the ParametersNameDecodingHandler only decodes query parameter names (and not values). I wrote a test case using the problem URLs that were linked in the issue.