Add PyQt6 multi-file GUI for MarkItDown - #2325
Add PyQt6 multi-file GUI for MarkItDown#2325Rahul Pawar (rahulpwar654) wants to merge 3 commits into
Conversation
|
@microsoft-github-policy-service agree |
Razin M (R-zin)
left a comment
There was a problem hiding this comment.
for source_file in self._selected_files:
result = converter.convert(str(source_file))
If you use this then when a large PDF or any file is queued for conversion it uses the same thread for the Qt GUI as well (The GUI can freeze) so I think you should spawn a Worker Thread which will handle MarkItDown.convert() function which will be on separate thread and when it finishes it can update the Qt thread. You can even add a progress bar in GUI also.
Razin M (R-zin)
left a comment
There was a problem hiding this comment.
for source_file in self._selected_files:
result = converter.convert(str(source_file))
If you use this then when a large PDF or any file is queued for conversion it uses the same thread for the Qt GUI as well (The GUI can freeze) so I think you should spawn a Worker Thread which will handle MarkItDown.convert() function which will be on separate thread and when it finishes it can update the Qt thread. You can even add a progress bar in GUI also.
|
Changes in _qt_gui.py: MarkItDown.convert() now runs inside a QObject worker moved to a QThread. |
markitdown-guidesktop app implementation