Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mi_cfree function missing certain big allocations #915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mi_cfree function missing certain big allocations #915

wants to merge 1 commit into from

Commits on Jul 15, 2024

  1. Fix mi_cfree function missing certain big allocations 

    The way `mi_is_in_heap_region` is implemented right now (see [this](https://github.com/microsoft/mimalloc/blob/master/src/free.c#L112) code) it is possible to 'miss' certain huge allocations going through `mi_cfree`. So we either need to update the segment detection code (so that it is not limited to [e.g. 2GiB on 32-bit platforms](https://github.com/microsoft/mimalloc/blob/master/src/segment-map.c#L24)) or use the more expensive `mi_check_owned` check if we've failed the simpler heap check.
    @kerambyte
    kerambyte authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6f29441 View commit details
    Browse the repository at this point in the history