Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing TS dependency for RN < 0.71 #272

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Feb 2, 2024

Now that typescript types are included in RN, they've deprecated the package @types/react-native, which unfortunately breaks creating new test apps for RN < 0.71 because RNX needs the types to do its codegen and they're no longer available.

This PR fixes our CI/PR workflows to use the typescript templates for the older versions so we get typescript and the proper RN types.

Microsoft Reviewers: Open in CodeFlow

@jonthysell jonthysell requested a review from a team as a code owner February 2, 2024 21:52
@jonthysell jonthysell merged commit 511b107 into microsoft:main Feb 2, 2024
16 checks passed
@jonthysell jonthysell deleted the fixtstemplates branch February 2, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants