Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve route string syntax usage #2253

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Improve route string syntax usage #2253

merged 2 commits into from
Sep 14, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 14, 2023 •
edited
Loading

  • Add internal StringSyntaxAttribute to remove #ifdefs
  • Add route string syntax to a few more places

After:

image

@Tratcher Tratcher merged commit 44629d6 into main Sep 14, 2023
7 checks passed
@Tratcher Tratcher deleted the jamesnk/improve-pattern-stringsyntax branch September 14, 2023 17:08
@Tratcher Tratcher added this to the YARP 2.x milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @Tratcher