Preserve variables in legacy GraphQL queries - #8889
Open
Tamir Duberstein (tamird) wants to merge 1 commit into
Open
Preserve variables in legacy GraphQL queries#8889Tamir Duberstein (tamird) wants to merge 1 commit into
Tamir Duberstein (tamird) wants to merge 1 commit into
Conversation
fd5f8d8 allowed legacy queries to replace their variables, but also cleared them when a caller supplied only a fallback query. PullRequestComments then retried without owner, name, or number, masking the original failure with invalid-variable errors. Keep the original variables unless the fallback supplies replacements. Cover both inherited and explicitly replaced variables at the repository query boundary.
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves GraphQL variables during legacy fallback queries, with regression coverage for inherited and replacement variables.
Changes:
- Retains original variables unless fallback values are supplied.
- Adds repository-level regression tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
src/test/github/githubRepository.test.ts |
Tests inherited and replacement variable behavior. |
src/github/githubRepository.ts |
Preserves variables during legacy fallback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fd5f8d8 allowed legacy queries to replace their variables, but also cleared them when a caller supplied only a fallback query. PullRequestComments then retried without owner, name, or number, masking the original failure with invalid-variable errors.
Keep the original variables unless the fallback supplies replacements. Regression coverage exercises both inherited and explicitly replaced variables at the repository query boundary.
Prepared with Codex.