Metadata parsing and indexing improvements #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update contains a collection of improvements to metadata handling, parsing, and indexing. Chiefly, the metadata reader now treats types, functions, and constants all as first-class citizens. Previously, only types were indexed which made sense for traditional WinRT metadata but Win32 metadata introduced free functions and constants that were harder to search for. No more!
This allows riddle to streamline how it handles filtering for APIs across namespace- or standalone-style code generation.
There's a bunch of code movement in the
windowsandwindows-syscrates as a result of this indexing where constants are now sorted properly according to kind, but otherwise appear in the same modules and are unchanged.