Address Rust nightly compiler warnings #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisDenton do you happen to know if this is a compiler bug? I searched the Rust repo but I couldn't find an issue related to this. |
|
This update also addresses another unrelated new warning about a |
kennykerr
changed the title
improper_ctypes warnings
kennykerr
changed the title
|
Seems like a totally spurious warning. I've opened an issue. It's being looked into. |
|
Thanks I left a comment to remove these when that issue is resolved. |
|
A revert has been merged so it should be fixed in the next nightly (aka tomorrow). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly Rust just started lighting up the
improper_ctypeswarning a "type is infinitely recursive" but it seems to be a false positive.You can see examples in the build failure here:
https://github.com/microsoft/windows-rs/actions/runs/10997420809/job/30532908394?pr=3291
And here:
https://github.com/microsoft/windows-rs/actions/runs/10997420795/job/30532923854?pr=3291
Workaround for rust-lang/rust#130757