-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed testing dependency #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the testing dependency, but change the test so it returns passed.
What is your reasoning for removing it? We don't want to publish broken code to NPM. Ensuring the test passes successfully before pushing to NPM is a critical step in ci/cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not remove testing from CI / CD.
The test requires a webchart system. I asked him to remove the dependency on webchart. I think the test should do something that can be done completely independent and later will simulate a WebChart system. |
Hi Will,
|
Awesome! Can you do me one last favor? It would be good to have the pull request run the npm test, that way we can make sure the tests are passing before merging into the main branch. You can add a second workflow file named "check-pull-request" and set the on to push. |
updated the .yml file to install the dependency to run npm test
Hey Will, I have added a GitHub actions to test the Pull request and run all the tests before merging it. Can you please check if that fine or any change is needed. |
Adding Test cases for ApiService
Removed testing dependency as this package has been tested locally using npm link.