Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lutim images integration in timeline #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lutim images integration in timeline #185

wants to merge 1 commit into from

Conversation

ldidry
Copy link

@ldidry ldidry commented Sep 27, 2014

Lutim is a free software for image sharing. This patch displays
images from the official instance (https://lut.im) in the Twister
timeline.

Lutim is a free software for image sharing. This patch displays
images from the official instance (https://lut.im) in the Twister
timeline.
@miguelfreitas
Copy link
Owner

please take a look at interface_common.js:462.
inline image displaying must obey getShowPreviewOpt() and getUseProxyOpt() options.

@ldidry
Copy link
Author

ldidry commented Sep 28, 2014

There is a problem with the proxies:

What do I have to do ? Adding an exception for the case the user want to use anonymouse.org ? (I hope that ssl-proxy.my-addr.org will be up again someday)

I've got two other questions:

  • it seems that no image at all are displayed in the twists list. While adding support for lut.im, maybe can I add support for other images ? Like in interface_common.js.
  • if I want to really support lut.im, I have to add support for it in interface_common.js, don't I ?

Thank you for your answers… and for Twister of course !

@miguelfreitas
Copy link
Owner

The most important thing is not the proxy itself, but rather implementing the image inline preview as a feature which can be enabled/disabled. User must be able to choose not to leak the information about which posts he reads (by accessing some arbitrary server who logs his activity).

btw, yes: we have image support in twister-html, but the user has to explicitly enable this at the options page.

So, first point: check that regex in line 462 on how you may be able to enhance it to include lut.im detection. Then lut.im will also be enclosed by the same test in line 455 (ie getShowPreviewOpt).

You have a good point about https, I was not aware of the proxies limitation. One possible solution is to only display lut.im images if proxies are not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants