Small fixes to personalized points goal

mikaelGusse · Aug 21, 2024 · 00cb5b4 · 00cb5b4
1 parent 4172f22
commit 00cb5b4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/exercise/static/exercise/personalized_points_goal.js b/exercise/static/exercise/personalized_points_goal.js
@@ -130,6 +130,8 @@ $(document).ready(function() {
 
                 // Update progress-bar style
                 $progressDiv.find('.progress-bar').removeClass('progress-bar-primary');
+
+                $('#deletePointsGoalForm').hide();
 
                 $('#remove-success-alert').show();
                 setTimeout(function() {

diff --git a/exercise/templates/exercise/_user_results.html b/exercise/templates/exercise/_user_results.html
@@ -107,7 +107,6 @@ <h3 class="panel-title">
 			{% csrf_token %}
 			{% if user.id %}
 				{% get_max_module_points module.id user.id as max_points %}
-				{% get_points_goal module.id user.id as points_goal %}
 				{% if max_points > 0 and user.id %}
 					<a class="page-modal aplus-button--secondary aplus-button--xs" style="float: right; margin-left: 5px;" role="button" href="{% url 'save_points_goal_form_view' course_slug=course.url instance_slug=instance.url module_slug=module.url %}" data-module-id="{{ module.id }}" title="{% translate 'POINTS_GOAL_TOOLTIP' %}" data-toggle="tooltip">
 						<span class="glyphicon glyphicon-screenshot" aria-hidden="true"></span> {% translate 'POINTS_GOAL' %}

diff --git a/exercise/templatetags/exercise.py b/exercise/templatetags/exercise.py
@@ -83,7 +83,7 @@ def get_max_module_points(module: int, student: int) -> int:
 
 
 @register.simple_tag
-def get_points_goal(module: int, student: int) -> int:
+def get_points_goal(module: int, student: int) -> Union[int, bool]:
     student = UserProfile.objects.get(id=student)
     module = CourseModule.objects.get(id=module)
     try: