Adds 'starting_filter_input' to Select #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The lint error doesn't seem to originate from my code. |
mikaelmello
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to set an initial filter value to the Select prompt.
My use-case it to allow the user to start a command with some initial input, if that doesn't match anything directly, build a Select prompt with their initial value as a starting point.
The current implementation does exhibit a (usual) problem, in that the contents is not yet filtered until the user takes another action. (for example, deleting a character). My first attempt at solving that resulted in a much larger PR, and would like your input if it is worth the effort (and if so, the best approach at solving it).
If this is something you could see working, I would be happy to add this to other prompts.