Fixed .With() in test cases to be generic. (#5)

Fixed test cases .With to be generic. Changed unit tests accordingly.
mikhailshilkov · Mar 4, 2017 · 7b9cffc · 7b9cffc
1 parent 41402d2
commit 7b9cffc
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/AssemblyToProcess/ConstructorWithSingleArgument.cs b/AssemblyToProcess/ConstructorWithSingleArgument.cs
@@ -11,6 +11,6 @@ public ConstructorWithSingleArgument(int value1)
 
         public string Value2 { get; set; }
 
-        public ConstructorWithSingleArgument With(object value) => this;
+        public ConstructorWithSingleArgument With<T>(T value) => this;
     }
 }
diff --git a/AssemblyToProcess/MultipleConstructors.cs b/AssemblyToProcess/MultipleConstructors.cs
@@ -19,7 +19,7 @@ public MultipleConstructors(int value1, string value2, long value3)
         public string Value2 { get; set; }
 
         public long Value3 { get; set; }
-
+      
         public MultipleConstructors With<T>(T value) => this;
     }
 }
diff --git a/AssemblyToProcess/MultipleConstructorsOnlyOneIsPublic.cs b/AssemblyToProcess/MultipleConstructorsOnlyOneIsPublic.cs
@@ -19,6 +19,6 @@ public MultipleConstructorsOnlyOneIsPublic(int value1, string value2)
 
         public string Value2 { get; }
 
-        public MultipleConstructorsOnlyOneIsPublic With(object value) => this;
+        public MultipleConstructorsOnlyOneIsPublic With<T>(T value) => this;
     }
 }
diff --git a/AssemblyToProcess/NoConstructor.cs b/AssemblyToProcess/NoConstructor.cs
@@ -6,6 +6,6 @@ public class NoConstructor
 
         public string Value2 { get; set; }
 
-        public NoConstructor With(object value) => this;
+        public NoConstructor With<T>(T value) => this;
     }
 }
diff --git a/AssemblyToProcess/NoMatchingProperty.cs b/AssemblyToProcess/NoMatchingProperty.cs
@@ -12,6 +12,6 @@ public NoMatchingProperty(int value1, string value2, long value3)
 
         public string Value2 { get; set; }
 
-        public NoMatchingProperty With(object value) => this;
+        public NoMatchingProperty With<T>(T value) => this;
     }
 }
diff --git a/AssemblyToProcess/PropertyCasing.cs b/AssemblyToProcess/PropertyCasing.cs
@@ -13,6 +13,6 @@ public PropertyCasing(int value1, string value2)
 
         public string vaLue2 { get; }
 
-        public PropertyCasing With(object value) => this;
+        public PropertyCasing With<T>(T value) => this;
     }
 }
diff --git a/Tests/WeaverTests.cs b/Tests/WeaverTests.cs
@@ -44,7 +44,7 @@ public void Setup()
     public void DoesNotSatisfyAllRules_NoWithIsInjected(string typeName)
     {
         var type = assembly.GetType($"AssemblyToProcess.{typeName}");
-        Assert.False(type.GetMethods().Any(m => m.Name.StartsWith("With") && m.GetParameters()[0].ParameterType != typeof(object)));
+        Assert.False(type.GetMethods().Any(m => m.Name.StartsWith("With") && !(m.IsGenericMethod && m.GetParameters().Length == 1)));
     }
 
     [TestCase("MultipleConstructors")]