-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
croaring-rs upgrade 0.5.2 -> 1.0.1 #3779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeastplume
changed the title
[WIP] croaring-rs upgrade
croaring-rs upgrade 0.5.2 -> 1.0.1
Feb 6, 2024
Also note this reverts the CI testing environment to the |
tromp
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, but this code needs to be made future proof in the next few years so it can support MMR indices beyond 2^32.
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to upgrade croaring-rs to 1.0.1, from 0.5.2, in an attempt to address odd instruction set issues such as found in mimblewimble/grin-gui#73
Note this has not yet been tested, and this is here as a first pass, mostly to determine whether it does indeed address issues. A windows test was failing on the CI server at
pow::lean::test::lean_miner
. If this no longer fails after the update, this is a good sign.Issues that need to be looked into:
Bitmap
functions that take a range are required to be u32 as opposed to u64 in croaring 0.5.6. I've just cast types for now, we need to confirm this is okay.Portable
(and seems to work with existing chain data, though I could still be wrong).store
appear to be failing following this update, and we need to trace why: