Minor updates to user docs - concepts #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sentence flow, headings, capitalisation
github-actions
bot
added
the
documentation
|
tom-webber
commented
Jun 26, 2024
|
|
||
| In a shared AWS account for a business unit, untaggable billable items such as Data Transfer become impossible to attribute to an application. | ||
| In a shared AWS account for a business unit, untaggable billable items such as Data Transfer cannot easily be attributed to a particular application. |
There was a problem hiding this comment.
untaggable billable items such as Data Transfer cannot easily be attributed to a particular application
Is this still the case (I don't have access to any cost allocation billing report to check)? https://repost.aws/questions/QUSiF9OHXiSqmYWZ4BbnAKeA/data-transfer-tagging
There was a problem hiding this comment.
Not entirely sure. This may be a comment from an historic perspective. It could now be, with tags and other items included, they can be. As you say access to specifics would be best to check this.
tom-webber
commented
Jun 26, 2024
| - people tend to go for the easiest option, which creates technical debt further down the line | ||
| - infrastructure quickly becomes hard to track | ||
| - it can become tangled and messy | ||
| - doesn't support the central alignment we're trying to achieve |
There was a problem hiding this comment.
doesn't support the central alignment we're trying to achieve
I'd prefer to reword this *that this be reworded, as it's not clear to me exactly what this means
There was a problem hiding this comment.
If you feel this needs to be reworded you could send out an example to the whole team to see if anyone has complaints/suggestions.
There was a problem hiding this comment.
Personally? This is an early way of describing what P&A exists to do through hosting teams.
|
|
|
update lychee command to use config toml
|
tom-webber
commented
Jun 28, 2024
| @@ -1,6 +1,13 @@ | |||
| # Modernisation Platform: environments bootstrapping | |||
There was a problem hiding this comment.
I think this README might have been intended for the parent directory (terraform/environments/bootstrap)
There was a problem hiding this comment.
Agreed. Feel free to move it!
|
dms1981
reviewed
Jul 1, 2024
dms1981
reviewed
Jul 1, 2024
dms1981
reviewed
Jul 1, 2024
|
dms1981
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No associated issue. An update to the 'Concept' section of the user guide, and addition of a workflow to run on docs PRs to check whether external links are working.
Also includes:
Checklist (check
xin[ ]of list items)Additional comments (if any)
{Please write here}