Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: Cleanup GC code prior to file split #2105

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

Ngoguey42
Copy link
Contributor

@Ngoguey42 Ngoguey42 commented Oct 5, 2022

@metanivek In the end I prefered reimplementing read_bytes_exn because read_in_prefix_and_suffix_exn was not checking that the read in prefix was valid

I didn't add new tests for read_bytes_exn but #2092 still tracks this problem.

Please propose alternatives names for read_bytes_exn

Copy link
Member

@metanivek metanivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step towards the split!

src/irmin-pack/unix/dispatcher_intf.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher_intf.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher.ml Outdated Show resolved Hide resolved
src/irmin-pack/unix/dispatcher.ml Show resolved Hide resolved
@Ngoguey42 Ngoguey42 force-pushed the split-gc-file branch 2 times, most recently from ecc77f0 to 6e1c7db Compare October 6, 2022 11:46
@Ngoguey42 Ngoguey42 added the no-changelog-needed No changelog is needed here label Oct 6, 2022
@icristescu
Copy link
Contributor

Thanks, LGTM!

@Ngoguey42
Copy link
Contributor Author

Merge when green

@Ngoguey42 Ngoguey42 merged commit f83f1b4 into mirage:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants