Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Better error detection and handling #6

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

mishagp
Copy link
Owner

@mishagp mishagp commented Dec 19, 2023

Previous logic was faulty, updated to capture errors properly and add case-insensitive check too.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41f41b5) 94.14% compared to head (376c660) 94.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main       #6   +/-   ##
=========================================
  Coverage     94.14%   94.14%           
  Complexity       69       69           
=========================================
  Files             3        3           
  Lines           205      205           
=========================================
  Hits            193      193           
  Misses           12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mishagp mishagp merged commit 96a52b1 into main Dec 19, 2023
14 checks passed
@mishagp mishagp deleted the fix-error-handling branch December 19, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant