Preserve leading license comments from multiple files; //, /* and /*! #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mishoo any pointers for getting this merged would be most welcome; I know it doesn't solve the comment/license situation completely, but it is a step up from what we have to help bridge the gap until there's a comprehensive solution/2.0. |
I just discovered a bug in npm where a space between the `#!` and the `/usr/bin/env` is causing it to not realize that this is a node program when it's installing on windows. As a result, it doesn't set up the batch file properly. I'm fixing the bug in npm, but it would be very helpful if you could remove the space here, and republish as soon as you get a chance. Thanks!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a user to specify more than one input file to uglify, and keep the comments from each;
-can also be used to ask uglify to read input fromstdin. This operates in a similar manner to the currentbin/uglifyin that it will only preserve the comment block at the top of each file.Example
Changes
--defineaccepts regular expressions--strictapplies strict mode to outputNote
This does not solve the problem being addressed in #332, it just improves the existing workaround in
bin/uglifyjs.