Adapt to Coq's PR #18445 fixing inheritance of multiple signatures of implicit arguments in notations #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplicit arguments. Notations hiding constants with multiple signatures of implicit arguments now correctly inherits the underlying multiple signatures of implicit arguments (bug fixed by Coq PR #18445). We adapt by changing the notation so that it becomes indifferent to potential insertion of maximal implicit arguments.
2 tasks
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With coq/coq#18445, notations hiding constants with multiple signatures of implicit arguments inherit as expected the underlying implicit arguments.
File
src/Compilers/Named/ContextProperties/Proper.vwas depending on the "bug". We adapt it by changing the notation so that it becomes indifferent to potential insertion of maximal implicit arguments.Note that this is one possible fix among others (for instance, it is probably also possible to change the signatures of the underlying constant).
It is (a priori) backwards compatible and can be merged as soon as now.