-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reddit slash links #32
Open
jimmyjxiao
wants to merge
18
commits into
mity:master
Choose a base branch
from
jimmyjxiao:Reddit-Slash-Links
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d210957
Add mostly-complete support for Reddit-style autolinks
DemiMarie 4a8f087
Finish Reddit autolinks
DemiMarie e9295c0
Merge remote-tracking branch 'ral/reddit' into Reddit-Slash-Links
jimmyjxiao 19e6c59
Fully working Reddit slash links
jimmyjxiao c686873
Update md2html.c
jimmyjxiao 0129aa5
undo this because it breaks tests
jimmyjxiao 0d5d495
Update README.md
jimmyjxiao fda1114
fix some comments:
jimmyjxiao 93e9afd
change Reddit flag name
jimmyjxiao 6bd03e7
Remove Reddit autolinks as web links option from md4c
jimmyjxiao 4486040
untabify
jimmyjxiao f1e5e0e
rename Reddit dialect option to ensure consistency
jimmyjxiao aff66bf
change md2html flags
jimmyjxiao 5233d98
add reddit autolinking to md2html and add tests
jimmyjxiao 70e8801
oops forgot to add some stuff to the last commit
jimmyjxiao 061d6f6
remove extra linebreak in tests
jimmyjxiao 3fb5f03
remove extra linebreaks
jimmyjxiao c959ac7
Update README.md
jimmyjxiao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
|
||
# Reddit Autolinks | ||
|
||
With the flag `MD_FLAG_REDDITAUTOLINKS`, MD4C enables extension for recognition Reddit usernames and subreddits. | ||
|
||
For reference, here is snudown's (Reddit's markdown parser) implementation [link](https://github.com/reddit/snudown/blob/master/src/autolink.c). | ||
|
||
Reddit autolinks can be prefixed by a a forward slash or not: r/test and /r/test both work. A link ends when a non-alphanumeric character is hit. The only such character allowed it an underscore. | ||
|
||
```````````````````````````````` example | ||
Here is a link to /r/askreddit by u/me. | ||
. | ||
<p>Here is a link to <a href="https://www.reddit.com/r/askreddit">/r/askreddit</a> by <a href="https://www.reddit.com/u/me">u/me</a>.</p> | ||
```````````````````````````````` | ||
|
||
A link can show up in the middle of the word if prefixed by a forward slash (you don't need a whitespace before). | ||
|
||
```````````````````````````````` example | ||
World/r/news vs /r/worldnew;s | ||
. | ||
<p>World<a href="https://www.reddit.com/r/news">/r/news</a> vs <a href="https://www.reddit.com/r/worldnew">/r/worldnew</a>;s</p> | ||
```````````````````````````````` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a minor detail, but please swap 'r' and 'R' so that there is some consistency: Lower case for dialect options, upper case for extensions.