Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game Speed 3 levels, 1-4-8 #162

Closed
wants to merge 1 commit into from
Closed

Conversation

smarek
Copy link
Contributor

@smarek smarek commented Jun 10, 2019

Honestly, in some situations I find 4x speed too slow for testing out strategies
This patch cycles speeds on button press between 1x, 4x and 8x

@m4rkusxxl
Copy link

I dont know if some fixed values (1/4/8) are okay, to cycle through. (If you want to go to 1x from 4x you need to go over 8x?)

Maybe pop up a slider when pushing the button (pausing the game for the time it is displayed), where you can select a speed with the slider and the game proceeds with the selected speed when the slider is released?

Dont know if speed below 1x are neccessary?
Is 8x enough? (Actually waves 140+ take a looong time at 4x already. 8x will just cut that time in half.)

@smarek
Copy link
Contributor Author

smarek commented Sep 2, 2019

@m4rkusxxl yes, i'm aware of that downside, however it should be pretty easy to replace the button source with settings, where you could pick up 2 or more speed values, and make chain such as 1,4,1,8 which wouldn't kick your butt in case you need to slow down the game, however clicking fast enough shouldn't be problem too, we're talking fractions of second to go from 4x to 1x over 8x

However, the solution in PR i proposed is fine with me, and if you want to propose another mechanism, your PR will be, i suppose, welcome :)

@mjaun
Copy link
Owner

mjaun commented Aug 10, 2020

Closing this one because a similar mechanism is included in #175. Sorry I did not get back to you. But thanks for your contribution anyway!

@mjaun mjaun closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants