test(e2e): L5 hard-nav instant shell for marketing routes - #177
Draft
mkayander wants to merge 1 commit into
Draft
Conversation
Add instant-marketing-hard-nav spec using @next/playwright instant() on MPA reload. Tests auto-skip under next dev (instant MPA CSR-bails) and run on production/preview PPR shells. Update L5 docs with follow-ups.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues L5 after #176 merge with the next TODO item: initial page-load (hard navigation) instant shell validation for marketing routes.
Changes
e2e/instant-marketing-hard-nav.spec.ts— uses@next/playwrightinstant()on MPAreloadfor/,/privacy, and/dailynext dev(instant MPA mode CSR-bails; no prerendered shell in HTML)next build && next start, 3/3 pass)vibe-docs/Instant-Navigations-TODO.md,Locale-Migration-Design.md, andInstant-Navigations-Design.mdFollow-ups (documented, not in this PR)
instantadoption (optional)Testing
pnpm exec playwright test e2e/instant-marketing-hard-nav.spec.ts— 3 skipped on dev (expected)PLAYWRIGHT_BASE_URL=http://localhost:3001 pnpm exec playwright test e2e/instant-marketing-hard-nav.spec.ts— 3/3 pass on production serverpnpm test:ci— 471 pass