Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update argument names and descriptions in chakra_trace_link usage and guide #130

Closed
wants to merge 14 commits into from
Closed

Update argument names and descriptions in chakra_trace_link usage and guide #130

wants to merge 14 commits into from

Conversation

TaekyungHeo
Copy link
Contributor

@TaekyungHeo TaekyungHeo commented Jul 12, 2024 •
edited
Loading

Summary

Update argument names and descriptions in chakra_trace_link usage and guide.

This PR relies on the following PR. The PR below should be merged first.

Test Plan

CI passes

@TaekyungHeo
Add missing keyword in is_cuda_launch_op
8b2ddfc
@TaekyungHeo
Remove try-except to ensure trace_link stops on exception
3c75214
@TaekyungHeo
Adjust CI workflow to let vulture ignore fixtures
4e50038
@TaekyungHeo
Extract get_inter_thread_dep method to simplify link_ops
4615fa9
@TaekyungHeo
Add detailed docstrings to TraceLinker methods and refactor code
7df34b7
@TaekyungHeo
Add stream ID to GPU operators in the converter
b741128
@TaekyungHeo
Support multiple streams in simulate_execution
f995502
@TaekyungHeo
Add simulate option to PyTorchConverter
863ac54
@TaekyungHeo
Rename is_cuda_launch_op and add is_cuda_runtime_op, is_cuda_driver_o…
b1ad6ec 
…p methods.
@TaekyungHeo
Wrap the exclusive_dur docstring to a new line
06f7605
@TaekyungHeo
Rename is_arrow_op to is_ac2g_op and add excerpt from PyTorch documen…
8bc32ca 
…tation
@TaekyungHeo
Add unit tests for KinetoOperator methods
f193766
@TaekyungHeo
Add unit tests for TraceLinker
6e9989a
@TaekyungHeo
Update argument names and descriptions in chakra_trace_link usage and…
6170415 
… guide
@TaekyungHeo TaekyungHeo requested a review from a team as a code owner July 12, 2024 15:33
@TaekyungHeo TaekyungHeo added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 12, 2024
@github-actions GitHub Actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@TaekyungHeo TaekyungHeo deleted the update-trace-link-args branch July 16, 2024 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TaekyungHeo