clean up #1295
Merged
clean up #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added cmind.core.debug to make it easier to debug CM automations - added env CM_CORE_SKIP_FIX_REPO_PATH to skip fixing non-existent repo paths
## V2.3.6.1 - added cmind.core.debug to make it easier to debug CM automations - added env CM_CORE_SKIP_FIX_REPO_PATH to skip fixing non-existent repo paths
added core.debug and env CM_CORE_SKIP_FIX_REPO_PATH (#1293)
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
- added cmind.core.debug to make it easier to debug CM automations - added env CM_CORE_SKIP_FIX_REPO_PATH to skip fixing non-existent repo paths
|
Hi @arjunsuresh . Did I understand you correctly, that it's normal that the README check fails, here? If yes, should we merge this PR? I also just realized that I didn't create PR from my fork to dev but to main directly ... |
|
yes Grigori. I think it'll be good to just clean up all the broken links (there are many false positives like the linkedin URLs) and then restrict the check to only the links coming from the PR. Currently it is checking the entire repository. |
|
I see. Sure, that makes sense! I will ignore this test for now but let's wait for all other tests before merging other PRs ;) ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.