Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for SCC24 #18

Conversation

arjunsuresh
Copy link
Contributor

No description provided.

@arjunsuresh arjunsuresh requested review from a team as code owners September 24, 2024 23:06
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
1 out of 2 committers have signed the MLCommons CLA.
@arjunsuresh
❌ @admin
admin seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@morphine00
Copy link
Contributor

Hi folks, there are some commits under the name "admin", meaning that one of the users didn't set up their .git correctly for GitHub.

@arjunsuresh
Copy link
Contributor Author

arjunsuresh commented Sep 24, 2024 via email

@morphine00
Copy link
Contributor

Any authorized GitHub acount/token will do. Perhaps this is of help? https://github.com/orgs/community/discussions/25863 .

We can create an account just for this, but at first sight it looks like it's not necessary?

@arjunsuresh
Copy link
Contributor Author

Thank you @morphine00 . I tried to use the GitHub bot account where the user is actions-user. But this user still needs to be added in the MLCommons CLA right?

Created a committerMap for users in PR: (signed: arjunsuresh-4791823, ) , (notSigned:  admin-, actions-user-65916846, )
MLCommons CLA bot comment id:  2372542209

@morphine00
Copy link
Contributor

Hi Arjun, in the short term you can have the commits in question authored by you using one of the methods described below, and that'll get you past the CLA bot.

  1. However, there's a question raised here: do you foresee the Inference group needing a bot of their own for these actions?

  2. Note that regardless of whether you assign attribution of the commits to yourself using the methods below, or we create a bot, those commits and this PR will have to be re-done with the correct attribution. There are methods using Git to retroactively add user information to a commit, but that's generally more work than just redoing the PR.


(Options taken from ChatGPT, but it seems to make sense)

A. Signed-off-by Workflow: Ensure that commits made by bots are properly attributed and approved by a human who has signed the licensing agreement. You can implement a "Signed-off-by" footer for each commit, which adds a verifiable trail of human oversight for bot commits. GitHub’s --signoff option can be used when creating commits via bots or CI tools.

B. Co-Authored-by Commit Convention: For commits initiated by bots (such as through GitHub Actions), use the Co-authored-by convention, which allows for multiple authorship attribution. The bot can be listed as the primary author, but the team member who initiated or approved the action can be added as a co-author. This ties the commit back to a specific user who has signed the licensing agreement.

@arjunsuresh
Copy link
Contributor Author

Thank you @morphine00 . I'll take care of updating the commits in this PR.

But in all CM related repositories we do need a bot to automatically update the README files and also in the inference results repository (during the review period) to update the results summary via github actions. Do you think this github actions bot account is fine for this?
https://github.com/orgs/community/discussions/26560

@arjunsuresh arjunsuresh merged commit c4270cb into mlcommons:mlperf-inference-results-scc24 Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants