Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - SubmitInterface #301

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Fix - SubmitInterface #301

merged 3 commits into from
Sep 5, 2024

Conversation

shincap8
Copy link
Contributor

@shincap8 shincap8 commented Sep 5, 2024

Context

  • When going to Submit files in DCIC The information about the challenge wasn't brought. The call wasn't being made from the FrontEnd, so the user was only seeing this.

image

Changes Made

  1. Check for the correct variable sendCallDatasets to check if the call was being made. (The variable use was the function return by useState and not the variable)
  • This would allow the FrontEnd to call the backend just once as was pretended.

image

@shincap8 shincap8 requested a review from a team as a code owner September 5, 2024 20:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

remg1997
remg1997 previously approved these changes Sep 5, 2024
View reviewed changes
@shincap8 shincap8 merged commit 47985c4 into main Sep 5, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
@shincap8 shincap8 deleted the Fix/SubmitInterface branch September 5, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997