Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Email Host Port #302

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix - Email Host Port #302

merged 2 commits into from
Sep 9, 2024

Conversation

shincap8
Copy link
Contributor

@shincap8 shincap8 commented Sep 6, 2024 •
edited
Loading

Context

  • The credentials for SMTP has been changed so in order not to go to every file and line that has one of those credentials we are using variables

Changes Made

  1. Implement Host and Port variable in the Email and Email_sender class
  • This would allow us just to change those in the env file and not intervene the class files

Adding images as proof it works
image

@shincap8 shincap8 requested a review from a team as a code owner September 6, 2024 18:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@shincap8 shincap8 merged commit 8b44c56 into main Sep 9, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@shincap8 shincap8 deleted the Fix/email_host_port branch September 9, 2024 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997