Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - DB Session #304

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix - DB Session #304

merged 2 commits into from
Sep 13, 2024

Conversation

shincap8
Copy link
Contributor

Context

  • Dynabench DB is experiencing a lot of aborted clientes (The number of client connections that have not been closed properly)

Changes Made

  1. Implement Refresh session middleware in main.
  • This would allow the backend to close the session after every call.
  1. Implement Disconnect Handling - Pessimistic.
  • This would allow the backend to check if the session that will be used is in a good state.

@shincap8
add refresher middleware to close connections after a call and add po…
ed88e2b 
…ol_pre_ping when creating the connection engine
@shincap8 shincap8 requested a review from a team as a code owner September 13, 2024 17:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

remg1997
remg1997 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@remg1997 remg1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shincap8 shincap8 merged commit 2a7a246 into main Sep 13, 2024
13 checks passed
@shincap8 shincap8 deleted the Fix/DB_Session branch September 13, 2024 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997