remove redundant/extraneous submission_org and submission_platform fields from compliance checks before training v5.0 #395
+658
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of fields in the
results.txt
files that were made redundant (and therefor error prone and inconsistent) when we introduced thesystems/*.json
files in v1.0.This PR removes the compliance checker checks for the
submission_org
andsubmission_platform
fields from the training v5.0.0 compliance checker common.yaml file. (Since a training v5.0.0 compliance checker common.yaml didn't exist yet, I copied the one from training_v4.1.0).These two fields in the
result*.txt
files are redundant, and (other than their presence) are not used for anything or checked by any of the compliance or package checkers. They are difficult for many submitters to get correct in their submissions, and are often a source of confusion and/or extra work during the submission review period.Historically, there were originally 4 fields:
submission_platform
which is redundant with some combination of the sys.jsonsystem_name
, andnumber_of_nodes
fields. This PR removes the compliance check for this field from training v5.0.0.submission_org
which is now redundant with the sys.jsonsubmitter
field. This PR removes the compliance check for this field from training v5.0.0.submission_status
which was replaced by the sys.jsonstatus
field, and removed from the compliance checker before the v4.1.0 round (since it used values inconsistent with the values used in the sys.json).submission_division
which is now redundant with the sys.jsondivision
field. This PR does not remove the compliance check for this field from training v5.0.0 because the compliance checker uses this field to determine whether the maximal allowed initialization time is 30 minutes (closed division) or 240 minutes (open division).