-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Smoke Test #368
Automated Smoke Test #368
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
LGTM. Do we care about testing with other python versions? |
That's a great question! I think the idea here is to make sure we can communicate with the SUTs correctly, not to comprehensively test the operation of ModelBench, so I believe we probably don't care. But I'm open to being wrong! @wpietri , thoughts? |
Definitely a good question. Yes my intent here was about 10% smoke test for our CLI and 90% making sure that there are no external surprises. Given our other test coverage, I think we're good on Python version shenanigans, so let's try it without. But if reality surprises us, we should look at the question again. |
Makes sense to me! |
Theoretically, this runs a tiny benchmark every day at 12:00 UTC/8:00 EST. I say theoretically because there's apparently no way to test it if it's not on the main branch. I've tested the benchmark run itself and it works, but the scheduler is anybody's guess.