Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Smoke Test #368

Merged
merged 10 commits into from
May 14, 2024
Merged

Automated Smoke Test #368

merged 10 commits into from
May 14, 2024

Conversation

dhosterman
Copy link
Collaborator

Theoretically, this runs a tiny benchmark every day at 12:00 UTC/8:00 EST. I say theoretically because there's apparently no way to test it if it's not on the main branch. I've tested the benchmark run itself and it works, but the scheduler is anybody's guess.

@dhosterman dhosterman self-assigned this May 14, 2024
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bkorycki
Copy link
Contributor

LGTM. Do we care about testing with other python versions?

@dhosterman
Copy link
Collaborator Author

LGTM. Do we care about testing with other python versions?

That's a great question! I think the idea here is to make sure we can communicate with the SUTs correctly, not to comprehensively test the operation of ModelBench, so I believe we probably don't care. But I'm open to being wrong!

@wpietri , thoughts?

@wpietri
Copy link
Contributor

wpietri commented May 14, 2024

Definitely a good question. Yes my intent here was about 10% smoke test for our CLI and 90% making sure that there are no external surprises. Given our other test coverage, I think we're good on Python version shenanigans, so let's try it without. But if reality surprises us, we should look at the question again.

@bkorycki
Copy link
Contributor

Makes sense to me!

@dhosterman dhosterman merged commit 79f0cc9 into main May 14, 2024
4 checks passed
@dhosterman dhosterman deleted the automated-smoke-test branch May 14, 2024 17:10
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants