Add Lamassu entityCache ttls #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Sep 27, 2024
| @@ -53,6 +53,14 @@ org.entur.lamassu.baseUrl=${LAMASSU_BASE_URL} | |||
| org.entur.lamassu.feedupdateinterval=${LAMASSU_FEED_UPATE_INTERVAL_IN_MS:21600000} | |||
| # How long a feed should be cached, in case it is not updated in between, in seconds, default 6h | |||
| org.entur.lamassu.feedCacheMinimumTtl=${LAMASSU_FEED_CACHE_MINIMUM_INTERVAL_IN_S:21600} | |||
| # For entities, we set the cache (min and max ttl) to the feed cache interval as well. | |||
| # Note that the cache ttl should be greater than | |||
There was a problem hiding this comment.
Can you add an explanation why we do this, to make sure that future maintainers (us or others) don't run into the same problem as you did recently?
derhuerst
approved these changes
Oct 2, 2024
hbruch
force-pushed
the
lamassu/entity-cache-ttl
branch
from
10c0c36
to
1a14309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
lamassuto 2024-09-27T11-21. This i.e. includes thestationEntityCacheMinimumTtlandstationEntityCacheMaximumTtlconfiguration options.For these configuration options, the same value as the already configured
LAMASSU_FEED_CACHE_MINIMUM_INTERVAL_IN_Sis used.