add pgbouncer in between gtfs-db and gtfs-api/geoserver #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
force-pushed
the
gtfs-pgbouncer
branch
3 times, most recently
from
eeb4874
to
a33dfd9
Compare
derhuerst
force-pushed
the
gtfs-pgbouncer
branch
from
a33dfd9
to
7c75b05
Compare
derhuerst
force-pushed
the
gtfs-pgbouncer
branch
from
7c75b05
to
768a694
Compare
follow-up of 5fd6d5
This CI directly uses .env.local.example as .env.local, so it fails with an empty value.
derhuerst
force-pushed
the
gtfs-pgbouncer
branch
2 times, most recently
from
af3dfb0
to
d935e6e
Compare
derhuerst
force-pushed
the
gtfs-pgbouncer
branch
from
d935e6e
to
c3d8078
Compare
hbruch
reviewed
Nov 13, 2023
With the default parameters, it would sometimes not become healthy fast enough.
derhuerst
force-pushed
the
gtfs-pgbouncer
branch
from
c3d8078
to
959c494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all services accessing some (or multiple) PostgreSQL databases –
geoserver,dagster-pipeline,dagster-daemon,dagster-dagit,gtfs-api– to connect via a newpgbouncerservice.geoserver&gifs-apistill requires a complex process, but it is located in one service only and therefore much less brittle.dragster-*&dagster-postgresqlwill likely speed up Dagster runs, because we assume that currently,dagster-pipelineexcessively establishing new connections to the DB causes significant load.Note:
The PR currently uses a bespoke & temporary Docker imageIt got merged, we're usingderhuerst/pgbouncer:1-pgbouncer-dsn-i-file. If bitnami/containers#51830 gets merged, we can use the upstreambitnami/pgbouncer:1image again. If it doesn't get merged, we can still revert to letting a script generate apgbouncer.inifrom a template.bitnami/pgbouncer:1again.