Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for username+password from the URL #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hgfischer
Copy link

No description provided.

@mobz
Copy link
Owner

mobz commented Feb 6, 2017

@hgfischer I've reviewed your patch. I think it would be preferable if the user/pass was more integrated into the way user/pass can be transferred as a url param of head, so that both mechanisms end up effecting the same control structure.

for example putting ?auth_user=foo in the browsers location bar adds Authorisation header via $.ajaxSetup. It would be good if they worked the same way. app.js around line 13 might be the right place for this.

I noticed also that you add call['xhrFields'] = { withCredentials: true }; which might be more generally useful as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants