Strengthen Duration::from_secs contract to exclude fractional seconds - #658
Open
Adkid-Zephyr wants to merge 1 commit into
Open
Conversation
Adkid-Zephyr
marked this pull request as ready for review
August 29, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duration::from_secsto return zero subsecond nanoseconds.Motivation
The current contract guarantees that the result is representation-safe and that its
secsfield equals the input, but it does not constrain the fractional component. An implementation can therefore preservesecs, add any valid number of nanoseconds, and still satisfy the contract.The new clause captures the documented whole-seconds semantics:
#[ensures(|duration| duration.nanos.as_inner() == 0)]Mutation evidence
The mutation kill rate increases from 0/3 to 3/3. The contract harnesses use unconstrained
u64inputs, nokani::assume, and a separate cover check reachesu64::MAX.Validation
MUTATION_MATRIX=PASSresult.nanos == 0cargo fmt --check: passedgit diff --check: passedThe production diff is contract-only and adds no precondition or runtime behavior change.
Related to the contract-strength discussion in #630.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.