fix(deps): bump js-yaml overrides to patched 3.15.1 / 4.3.1 - #2073
Open
cliffhall wants to merge 1 commit into
Open
fix(deps): bump js-yaml overrides to patched 3.15.1 / 4.3.1#2073cliffhall wants to merge 1 commit into
cliffhall wants to merge 1 commit into
Conversation
The root `overrides` block pinned js-yaml to versions inside the advisory range (3.15.0 and 4.2.0), so `npm audit fix` reported a fix as available and then changed nothing — overrides take precedence. Bumps both pins to the patched `v3-legacy` / `v4-legacy` releases, addressing GHSA-52cp-r559-cp3m and GHSA-5p4m-2wfm-xmqj. Exposure is development-only: `npm ls js-yaml --omit=dev` is empty and both copies are reachable only via eslint and ts-jest/istanbul, neither of which ships in the published package. Both patched versions have an identical dependency and bin shape, so the lock entries were patched in place — 6 lines, no transitive churn. Fixes #2072 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gq5jMmxRUphrVbfNbYVmQH
This was referenced Aug 22, 2026
There was a problem hiding this comment.
Pull request overview
Updates development-only js-yaml overrides to patched releases, resolving #2072 without unrelated dependency churn.
Changes:
- Bumps legacy 3.x and 4.x override pins.
- Updates corresponding lockfile metadata and integrity hashes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Pins patched js-yaml versions. |
package-lock.json |
Updates both resolved package entries. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2072
Problem
The root
overridesblock pinnedjs-yamlto versions that sit inside the advisory range, sonpm audit fixreported "fix available" and then changed nothing — overrides take precedence over anything audit wants to do.Advisories: GHSA-52cp-r559-cp3m, GHSA-5p4m-2wfm-xmqj — CPU-exhaustion DoS on parsing untrusted YAML.
Exposure
Development-only.
npm ls js-yaml --omit=devis empty; both copies are reachable only viaeslint -> @eslint/eslintrcandts-jest -> @jest/transform -> babel-plugin-istanbul -> @istanbuljs/load-nyc-config. Neither ships in the published package, and the only YAML they parse is the repo's own eslint/nyc config. Audit hygiene, not a user-facing exposure — see #2072 for the full assessment.Change
Both pins bumped to the patched
v3-legacy/v4-legacyreleases:The patched versions have an identical dependency and
binshape to the ones they replace, so the two lock entries were patched in place (version/resolved/integrityonly). Total diff: 8 lines across 2 files, zero transitive churn.Verification
js-yamlno longer appears innpm auditnpm run build✅ ·npm run lint✅ (prettier + eslint)HTTP 200); proxy auth gates correctly (401 without token, 200 with)tools/listandtools/callboth return correctlyNote on branch policy
AGENTS.mddirects agents to file an issue rather than open a PR againstv1/main. This PR was opened at the explicit direction of a maintainer (@cliffhall), with #2072 filed and tracked on the Inspector V1 board alongside it.Not included
allowScriptsblock npm 11.19 writes topackage.json(fromnpm install-scripts deny) is unrelated to this fix and was deliberately left out.npm auditonv1/maincurrently reports 7 further advisories that postdate this one, several production-reachable in the proxy server (hono,@hono/node-server,ip-address,fast-uri— SSRF / host-confusion class). Being assessed separately; more likely to warrant a v1 release than this.🤖 Generated with Claude Code
https://claude.ai/code/session_01Gq5jMmxRUphrVbfNbYVmQH