fix: specify closure handler signature - #475
Draft
simonyang08 wants to merge 1 commit into
Draft
Conversation
simonyang08
marked this pull request as ready for review
August 22, 2026 06:07
simonyang08
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
August 22, 2026 06:07
simonyang08
marked this pull request as draft
August 22, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closurealias an explicit variadic signatureRegistryInterfacewithout a missing callable signature errorRoot cause
The
HandlerPHPStan alias used a bare\Closure, so consumers inheriting the alias receivedmissingType.callableunder strict analysis.Current validation status
ReferenceHandlerTest: 4 tests, 9 assertions passgit diff --check: passesUpstream CI exposed a variance conflict that the isolated reproducer missed: the proposed
Closure(mixed...): mixedtype rejects the repository's valid handlers with narrower required parameter lists. The full PHPStan job reports 29argument.typeerrors introduced by this alias. The PR is therefore intentionally Draft while the correct way to represent an arbitrary Closure signature is discussed; the current commit should not be merged as-is.Fixes #468