fix(qoder): recover incomplete forward destroys - #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cascadeto archive an in-use Forward Environment when Qoder rejects physical deletion.Why
Destroy was blocked by a configured default Memory Store that could not have been created because neither owner was present in local state. After fixing that, Qoder rejected the in-use Forward Environment and directed the caller to archive it.
Type
Surface area
Checklist
bun run verify:fullpassesBehavior / risk
When neither a Template nor an Identity is tracked, destroy no longer invents a default Memory Store cleanup dependency. A partially tracked owner set remains protected. For Qoder Forward, an environment that cannot be deleted due to retained session references is archived only after explicit
--cascade.Validation
bun scripts/verify.ts push(pre-push hook)bun test packages/sdk/tests/unit/destroy-runtime.test.ts packages/sdk/tests/unit/qoder-forward-template.test.tsbun run --cwd packages/sdk typecheck