Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing meta file in Zenject package #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrCheez
Copy link

@MrCheez MrCheez commented Jul 5, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • No compiler errors or warnings

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Issue Number

Issue Number: #221

What is the current behavior?

  • The Unity package version is missing a .meta file for the OptionalExtras/Async folder
  • Adding Zenject via UPM results in a UPM exception:
    image

What is the new behavior?

  • The .meta file of the UnityProject/Assets/Plugins/Zenject/OptionalExtras/Async folder has been added to the repository
  • Cloning the Zenject package via UPM no longer results in a missing meta file for immutable files exception

Does this introduce a breaking change?

  • Yes
  • No

Other information

On which Unity version has this been tested?

  • 2020.4 LTS
  • 2020.3
  • 2020.2
  • 2020.1
  • 2019.4 LTS
  • 2019.3
  • 2019.2
  • 2019.1
  • 2018.4 LTS

Scripting backend:

  • Mono
  • IL2CPP

Note: Every pull request is tested on the Continuous Integration (CI) system to confirm that it works in Unity.

Ideally, the pull request will pass ("be green"). This means that all tests pass and there are no errors. However, it is not uncommon for the CI infrastructure itself to fail on specific platforms or for so-called "flaky" tests to fail ("be red"). Each CI failure must be manually inspected to determine the cause.

CI starts automatically when you open a pull request, but only Releasers/Collaborators can restart a CI run. If you believe CI is giving a false negative, ask a Releaser to restart the tests.

@MrCheez
Copy link
Author

MrCheez commented Aug 10, 2021

Is there anything I can do to speed up the merge/review process @Mathijs-Bakker @nonumpa?

@nonumpa
Copy link

nonumpa commented Aug 25, 2021

I have no idea. I approved just because I also need this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants