Also keep any Addressable Resource manager on Context Clean #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is a Unity Package I think it should be added here (although in the long run there should be a way to specify additional files to keep depending on packages/own services). I pulled my hair out on this one. My tests where basically just hanging in the void because async operations where not finishing anymore due to this GO suppression.
|
This issue still occurs in Unity 2021.3.4f1. Quick explanation: ZenjectIntegrationTestFixture calls ZenjectTestUtil.DestroyEverythingExceptTestRunner(true) for setup on every test. This removes all gameobjects, except for the tet runner, unfortunately also removing ResourceManagerCallbacks which is responsible for loading Addressables properly. Without this, addressables will load but will not invoke 'Complete' callback, making your tests stuck if they wait for an asset or a scene to load. Please merge this in |
GorrionMW
approved these changes
Aug 3, 2022
|
We did this workaround within our "zenject mirror fixture". This is totally legit. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is a Unity Package I think it should be added here (although in the long run there should be a way to specify additional files to keep depending on packages/own services).
I pulled my hair out on this one. My tests where basically just hanging in the void because async operations where not finishing anymore due to this GO suppression.
Thank you for sending a pull request! Please make sure you read the contribution guidelines
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
On which Unity version has this been tested?
Scripting backend: