Skip to content

fix(binarygrid_util): restore top assignment dropped with reshape - #2833

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-2831
Aug 31, 2026
Merged

fix(binarygrid_util): restore top assignment dropped with reshape#2833
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-2831

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

Fix #2831. #2794 switched several places where .shape was set directly to .reshape() calls instead, but dropped an assignment on one of them.

@wpbonelli wpbonelli added this to the 3.11 milestone Aug 31, 2026
@wpbonelli wpbonelli added the bug label Aug 31, 2026
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.5%. Comparing base (556c088) to head (7d41a7b).
⚠️ Report is 216 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2833      +/-   ##
===========================================
+ Coverage     55.5%    73.5%   +18.0%     
===========================================
  Files          644      659      +15     
  Lines       124135   132188    +8053     
===========================================
+ Hits         68947    97220   +28273     
+ Misses       55188    34968   -20220     
Files with missing lines Coverage Δ
flopy/mf6/utils/binarygrid_util.py 89.6% <100.0%> (-1.2%) ⬇️

... and 584 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli
wpbonelli merged commit 73af2a7 into modflowpy:develop Aug 31, 2026
22 checks passed
@wpbonelli
wpbonelli deleted the fix-2831 branch August 31, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: dimensions of modelgrid.top incorrect after round trip through dis.grb file for structured grid?

1 participant